feat: add a sha256 implementation which is optimized for unconstrained runtime #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good to go now. I've fixed the issue when building the benchmarks. |
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
TomAFrench
commented
Feb 4, 2025
TomAFrench
commented
Feb 4, 2025
| let mut h: STATE = INITIAL_STATE; | ||
| // Pointer into msg_block on a 64 byte scale | ||
| for i in 0..num_full_blocks { | ||
| let (msg_block, _) = build_msg_block(msg, message_size, BLOCK_SIZE * i); |
There was a problem hiding this comment.
As we don't use the msg_byte_ptr value, we can check to make sure that we're not unnecessarily calculating this value in build_msg_block for this case.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Description
Problem*
Resolves #7
Summary*
Throwing this up to start this work. We'd need to add better testing, remove all the duplicated code and restructure the library before merging this.
Additional Context
PR Checklist*
cargo fmton default settings.